activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gaohoward <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1351: ARTEMIS-1220 Diverted LargeMessage file...
Date Tue, 20 Jun 2017 10:47:21 GMT
GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1351

    ARTEMIS-1220 Diverted LargeMessage file corrupted during replication

    When a large message is being diverted, a new copy of the original
    message is created and replicated (if there is a backup) to the backup.
    
    In LargeServerMessageImpl.copy(long) it reuse a byte array to copy
    message body. It is possible that one block of date is read into
    the byte array before the previous read has been replicated,
    causing the replicated bytes to corrupt.
    
    If we make a copy of the byte array before replication, the corruption
    of data will be avoided.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis master_1220

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1351
    
----
commit d4c75a8a7b0b92328fff9d56951d187f6fdfcc3d
Author: Howard Gao <howard.gao@gmail.com>
Date:   2017-06-20T10:38:26Z

    ARTEMIS-1220 Diverted LargeMessage file corrupted during replication
    
    When a large message is being diverted, a new copy of the original
    message is created and replicated (if there is a backup) to the backup.
    
    In LargeServerMessageImpl.copy(long) it reuse a byte array to copy
    message body. It is possible that one block of date is read into
    the byte array before the previous read has been replicated,
    causing the replicated bytes to corrupt.
    
    If we make a copy of the byte array before replication, the corruption
    of data will be avoided.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message