activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clebert Suconic <clebert.suco...@gmail.com>
Subject Re: [GitHub] activemq-artemis pull request #1316: ARTEMIS-1205: AMQP Shared Durable Subsc...
Date Mon, 05 Jun 2017 15:16:24 GMT
I will want the full test. Just to be safe. Something I do on my box.
Just to be safe.

Will merge the afternoon.

On Mon, Jun 5, 2017 at 11:13 AM michaelandrepearce <git@git.apache.org>
wrote:

> Github user michaelandrepearce commented on a diff in the pull request:
>
>
> https://github.com/apache/activemq-artemis/pull/1316#discussion_r120130864
>
>     --- Diff:
> artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerSenderContext.java
> ---
>     @@ -738,17 +738,14 @@ private static String createQueueName(String
> clientId,
>                                               boolean shared,
>                                               boolean global,
>                                               boolean isVolatile) {
>     -      String queue = clientId == null || clientId.isEmpty() ? pubId :
> clientId + "." + pubId;
>     +      String queue = clientId == null || clientId.isEmpty() || global
> ? pubId : clientId + "." + pubId;
>     --- End diff --
>
>     And build is green :)
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
-- 
Clebert Suconic

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message