activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1307: [ARTEMIS-1196] Fix missing JSON support
Date Thu, 22 Jun 2017 16:19:08 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1307#discussion_r123557009
  
    --- Diff: artemis-features/src/main/resources/features.xml ---
    @@ -54,8 +54,8 @@
     		<bundle dependency="true">mvn:org.jboss.logging/jboss-logging/${jboss.logging.version}</bundle>
     		<bundle dependency="true">mvn:org.jgroups/jgroups/${jgroups.version}</bundle>
     
    -		<bundle dependency="true">mvn:org.apache.geronimo.specs/geronimo-json_1.0_spec/${json-p.spec.version}</bundle>
    -		<bundle dependency="true">mvn:org.apache.johnzon/johnzon-core/${johnzon.version}</bundle>
    +		<bundle dependency="true">mvn:org.apache.servicemix.specs/org.apache.servicemix.specs.json-api-1.1/2.8-SNAPSHOT</bundle>
    --- End diff --
    
    @gnodet I'm about to merge this.. although I'm squashing all your committs as one.. (there's
no need to keep individual committs).. 
    
    
    although... for my education here..what's the difference between org.apache.geronimo.specs
and servicemix? just wanted to know the difference.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message