activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdanekrh <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #617: ARTEMIS-607 Added interceptor support fo...
Date Wed, 21 Jun 2017 14:06:54 GMT
Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/617#discussion_r123258336
  
    --- Diff: docs/user-manual/en/intercepting-operations.md ---
    @@ -9,7 +9,9 @@ makes interceptors powerful, but also potentially dangerous.
     
     ## Implementing The Interceptors
     
    -An interceptor must implement the `Interceptor interface`:
    +All interceptors are protocol specific.
    +
    +An interceptor for the core protocol must implement the interface `Interceptor`:
    --- End diff --
    
    I'd change that to 
    
        implement the `Interceptor` interface
    
    sounds more like standard Java-speak to me that way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message