activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gemmellr <>
Subject [GitHub] activemq-artemis pull request #1337: ARTEMIS-1205: AMQP Shared Durable Subsc...
Date Tue, 13 Jun 2017 17:32:52 GMT
Github user gemmellr commented on a diff in the pull request:
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/
    @@ -155,6 +155,7 @@ protected ActiveMQServer createServer(int port) throws Exception {
+ port);
    +      server.getConfiguration().setUseLegacyAMQPQueueNaming(false);
    --- End diff --
    I don't think the tests should override the default like this, it means none of the tests
would be testing the default behaviour of the broker. Explicit tests that verify non-default
behaviours would be more appropriate.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message