activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gemmellr <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1337: ARTEMIS-1205: AMQP Shared Durable Subsc...
Date Tue, 13 Jun 2017 17:32:52 GMT
Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1337#discussion_r121735447
  
    --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerSenderContext.java
---
    @@ -733,20 +734,31 @@ private static boolean hasCapabilities(Symbol symbol, Source source)
{
           return false;
        }
     
    -   private static String createQueueName(String clientId,
    +   private static String createQueueName(boolean useLegacyQueueNaming,
    +                                         String clientId,
                                              String pubId,
                                              boolean shared,
                                              boolean global,
                                              boolean isVolatile) {
    -      String queue = clientId == null || clientId.isEmpty() || global ? pubId : clientId
+ "." + pubId;
    -      if (shared) {
    -         if (queue.contains("|")) {
    -            queue = queue.split("\\|")[0];
    -         }
    -         if (isVolatile) {
    -            queue = "nonDurable" + "." + queue;
    +      if (useLegacyQueueNaming) {
    +         String queue = clientId == null || clientId.isEmpty() ? pubId : clientId + "."
+ pubId;
    --- End diff --
    
    This line looks to be restoring the original bug where the container-id (here being passed
as clientId, when really the JMS client has no ClientID, and so uses a 'global subscription')
was added to the queue name for global subscriptions when it shouldn't have been?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message