activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1326: ARTEMIS-1205: AMQP Shared Durable Subscriber i...
Date Thu, 08 Jun 2017 22:55:41 GMT
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1326
  
    We should note, as per JMS Spec:http://docs.oracle.com/javaee/7/api/javax/jms/Session.html#unsubscribe-java.lang.String-
    
    "
    A shared durable subscription and an unshared durable subscription may not have the same
name and client identifier (if set). If an unshared durable subscription already exists with
the same name and client identifier (if set) then a JMSException is thrown.
    "
    
    This means the current behaviour in AMQP here is wrong, as shared and unshared with the
same subscription name are not making the same queue as such above is invalid. 
    
    e.g. if clientId = myClient;
    
    createSharedDurableConsumer(myTopic, "mySub")
    will create myClient.mySub:global
    
    createDurableConsumer(myTopic, "mySub")
    will create myClient.mySub
    
    Essentially we should look to remove the :global part still in the shared part, otherwise
this is breaking spec. 
    
    this also wouldn't break anything already historically, as SharedDurable is not in a working
state.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message