activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gemmellr <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1316: ARTEMIS-1205: AMQP Shared Durable Subscriber i...
Date Thu, 08 Jun 2017 18:57:32 GMT
Github user gemmellr commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1316
  
    The no-ClientID shared-subscription behaviour was indeed broken for AMQP JMS clients.
Fixing that issue requires ensuring the container-id is not included in their backing queue
name by the broker. Changing those queue names in that way wouldnt break existing AMQP JMS
no-ClientID shared-subscription usage because they were already broken. All good.
    
    Introducing the alignment changes in addition to fixing the container-id bug does however
introduce other issues that were not previously present for AMQP clients (see the JIRA for
some examples), and additionally the latest change to fix alignment of "." handling could
actually break existing working subscriptions upon upgrade. So I'd say the question is, is
the alignment important enough to introduce those issues for AMQP clients and also potentially
break some existing subscriptions? I'm not sure it is, but even if so I'm also not sure I'd
do it in a minor version, and at a major version change I would probably instead consider
changing the Core side.
    
    I'm heading out shortly, so I won't be around for further replies this evening.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message