activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TomasHofman <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1311: ARTEMIS-1187 Incompatible version when ...
Date Thu, 01 Jun 2017 14:41:24 GMT
Github user TomasHofman commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1311#discussion_r119632869
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
    @@ -643,7 +643,7 @@ protected CreateSessionMessage newCreateSession(String username,
                                                        boolean autoCommitSends,
                                                        boolean autoCommitAcks,
                                                        boolean preAcknowledge) {
    -      return new CreateSessionMessage(name, sessionChannel.getID(), VersionLoader.getVersion().getIncrementingVersion(),
username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge,
confirmationWindow, null);
    --- End diff --
    
    OK, 1.x and 1.5.5-x PRs should be good now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message