Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
MIME-Version: 1.0
References: <7E4A1357-DCC3-470E-96D2-2D6131FCCA22@me.com>
In-Reply-To: <7E4A1357-DCC3-470E-96D2-2D6131FCCA22@me.com>
From: Clebert Suconic <clebert.suconic@gmail.com>
Date: Wed, 10 May 2017 00:57:56 +0000
Message-ID: <CAKF+bsqY3Rcrhit2fUk2=B_mb3O2NHCSw-D2tTkEmGp4RUdDTg@mail.gmail.com>
Subject: Re: CopyMessageBuffer
To: dev@activemq.apache.org
Content-Type: multipart/alternative; boundary="001a11468e1c250cc5054f20f74f"
archived-at: Wed, 10 May 2017 00:58:11 -0000

--001a11468e1c250cc5054f20f74f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

from what I remember it's where the message body gets created.


The packet impl buffer should be pooked while the message not (at least not
yet)

I want to do another major improvement next release where I use ref counts
on messages and also keep them pooked.  But paging was a bit issue now.


I can take a look tomorrow. I'm saying all this from memory.  I will need
to review the code if there is any duplication not necessary now.

Using the iPhone.


Clebert


On Tue, May 9, 2017 at 8:04 PM Michael Andr=C3=A9 Pearce <
michael.andre.pearce@me.com> wrote:

> Hi
>
> During some testing we decided to turn on a jvm profiler to see what
> allocations were occurring under load causing gc pressure.
>
> We see approx 25% (it varies obv over time) is an on heap byte[] caused b=
y
> copyMessageBuffer method in PacketImpl.
>
> Is there a reason why we create a new buffer and copy the data causing a
> new on heap byte[]
>
> Cheers
> Mike
>
> Sent from my iPhone

--=20
Clebert Suconic

--001a11468e1c250cc5054f20f74f--