Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: jbertram <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1269-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1269-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis issue #1269: Refactory to polimorphic creation connection f...
Content-Type: text/plain
Message-Id: <20170513174332.13306DFFB3@git1-us-west.apache.org>
Date: Sat, 13 May 2017 17:43:32 +0000 (UTC)
archived-at: Sat, 13 May 2017 17:43:34 -0000

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1269
  
    Couple of things...
    
    - I think this warrants a JIRA. Please open a JIRA at https://issues.apache.org/jira/browse/ARTEMIS with a summary of the issue. Then reference the JIRA in your commit message as described in the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/code.md#commitMessageDetails).
    - The PR build failed because you have not added @Overrides to the proper methods. See [the Maven log](https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build/2993/console) of the PR build for more details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---