Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: jbertram <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1204-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1204-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis issue #1204: ARTEMIS-1112: don't block live activation if a...
Content-Type: text/plain
Message-Id: <20170502132349.A1BB9DFBC8@git1-us-west.apache.org>
Date: Tue,  2 May 2017 13:23:49 +0000 (UTC)
archived-at: Tue, 02 May 2017 13:23:51 -0000

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1204
  
    To be clear, the issue isn't one of "backwards compatibility." The issue is that there are tests which rely specifically on the blocking behavior. Therefore, if you change the blocking behavior (i.e. remove it) then you can address it one of several ways...
    
    - change the tests so they don't rely on start() blocking and pass when start() is non-blocking
    - allow start() to block so the tests still pass and introduce a way to make start() non-blocking via configuration (which is what you suggested earlier)
    - change some other behavior to get the functionality you're looking for (which is what I suggested in regards to making stop() non-blocking)
    
    If you're satisfied with your current solution (i.e. checking the bindings directory) that's fine, but it's worth noting that this could change (but probably won't) at any time. In other words, you're relying on something that is not guaranteed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---