activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yourcaptain <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1301: CLI Create command may cause un-replace...
Date Tue, 30 May 2017 08:09:58 GMT
GitHub user yourcaptain opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1301

    CLI Create command may cause un-replaced keys contained in broker.xml

    As HashMap does not supply predictable iteration order,  the variable
    "HashMap filters = new HashMap()" defined in 
    org.apache.activemq.artemis.cli.commands.Create is dangerous, some keys
    ,let's say '${cluster-password},  may be put before '${cluster-security-settings}'.
    as a result, '<cluster-password>${cluster-password}</cluster-password>' may
    appear in broker.xml, without replacing the hash map key '${cluster-password}'
    to user defined value.
    I use LinkedHashMap to resolve this problem.
    Please check it.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yourcaptain/activemq-artemis cli-create

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1301.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1301
    
----
commit cb1212658bf2491c225be8483c73bc8b594c1e27
Author: 老袁 <17010538@cn.suning.com>
Date:   2017-05-30T07:59:46Z

    cli-create: change filters datatype to LinkedHashMap

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message