activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aibaars <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1252: Remove dangling git-link
Date Thu, 04 May 2017 11:38:19 GMT
GitHub user aibaars opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1252

    Remove dangling git-link

    The empty folder artemis-server/artemis-load-generator seems to be a git submodule link.
However, there is no submodule configuratation file (ie .gitmodules) in this repository.
    
    This caused the 'git submodule' command to fail with the following error message:
    fatal: no submodule mapping found in .gitmodules for path 'artemis-server/artemis-load-generator'
    
    The dangling link seems to have been introduced by 10c9d797d1ad5804c988f2c1a0b6445f190ba896
    
    @mtaylor Was this an accident, or is there a good reason for the dangling link?
    
    I am part of the team at [lgtm.com](https://lgtm.com) and  we wondered why the page https://lgtm.com/projects/g/apache/activemq-artemis/alerts/
stopped updating about a month ago. It turns out the dangling git link caused our analysis
to fail. Even though, we'll make our analysis more robust against such issues, I thought you
might want to know about it and have it fixed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aibaars/activemq-artemis remove-dangling-gitlink

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1252
    
----
commit 38a5b55767a896367f71f9d17f4498f2737e4fc9
Author: Arthur Baars <arthur@semmle.com>
Date:   2017-05-04T11:21:33Z

    Remove dangling git-link
    
    The empty folder artemis-server/artemis-load-generator seems to be a
    git submodule link. However, there is no submodule configuratation
    file (ie .gitmodules) in this repository.
    
    This caused the 'git submodule' command to fail with the following
    error message:
    fatal: no submodule mapping found in .gitmodules for path 'artemis-server/artemis-load-generator'

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message