activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jamezp <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1249: Use the org.jboss.slf4j:slf4j-jboss-log...
Date Wed, 03 May 2017 22:57:24 GMT
GitHub user jamezp opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1249

    Use the org.jboss.slf4j:slf4j-jboss-logmanager binding to allow slf4j…

    … to bind to the jboss-logmanager
    
    It looks like the Artemis server uses the JBoss Log Manager as it's log manager. Added
a dependency to the slf4j binding to avoid the slf4j binding error.
    ```
    SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
    SLF4J: Defaulting to no-operation (NOP) logger implementation
    SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    ```
    
    The `org.jboss.slf4j:slf4j-jboss-logmanager` library is under the Apache license.
    
    The dependency may also be needed by any other executable that uses jboss-logmanager,
including tests. I only added it to the distribution however for simplicity and to keep the
change at a minimal.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jamezp/activemq-artemis slf4j-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1249
    
----
commit 93ed7d1d91cb30e07c8aea86eda061942efd5ae2
Author: James Perkins <jperkins@redhat.com>
Date:   2017-05-03T22:51:46Z

    Use the org.jboss.slf4j:slf4j-jboss-logmanager binding to allow slf4j to bind to the jboss-logmanager

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message