activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1304: ARTEMIS-1189 - Fix checkstyle violation...
Date Tue, 30 May 2017 17:21:48 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1304#discussion_r119162241
  
    --- Diff: etc/checkstyle.xml ---
    @@ -73,7 +71,7 @@ under the License.
           <module name="RightCurly"/>
           <module name="RightCurly">
              <property name="option" value="alone"/>
    -         <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR,
LITERAL_WHILE, STATIC_INIT, INSTANCE_INIT"/>
    +         <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR,
LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
    --- End diff --
    
    as it states on the link i sent
    
    "The problem was due to the fact that we treated LITERAL_DO incorrectly in Checkstyle
6.19. After fix for issue #3090 RightCurlyCheck began validate next part of do-while loop
(while-token) correctly."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message