activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1295: ARTEMIS-1185 Inter-Process Journal Samp...
Date Tue, 30 May 2017 07:04:17 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1295#discussion_r119024088
  
    --- Diff: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/counters/Profiler.java
---
    @@ -0,0 +1,72 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.activemq.artemis.core.io.buffer.counters;
    +
    +import java.io.File;
    +import java.io.IOException;
    +
    +import org.apache.activemq.artemis.journal.ActiveMQJournalLogger;
    +
    +/**
    + * Factory class to instantiate {@link FlushProfiler}s classes.
    + */
    +public final class Profiler {
    +
    +   private static final FlushProfiler BLACK_HOLE_PROFILER = new FlushProfiler() {
    --- End diff --
    
    The ``default`` method idea is good IMHO when you've methods not bounded each others,
but when you have methods that makes sense to be implemented (and called) together (eg Lock::lock
and Lock::unlock), I prefer to use normal methods and force the implementation to have both.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message