activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1295: ARTEMIS-1185 Inter-Process Journal Samp...
Date Mon, 29 May 2017 20:31:26 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1295#discussion_r118983292
  
    --- Diff: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.java
---
    @@ -93,10 +82,10 @@
        public TimedBuffer(final int size, final int timeout, final boolean logRates) {
           bufferSize = size;
     
    -      this.logRates = logRates;
    -
           if (logRates) {
    -         logRatesTimer = new Timer(true);
    +         this.flushProfiler = Profiler.instrumented();
    +      } else {
    +         this.flushProfiler = Profiler.none();
    --- End diff --
    
    would it not be better to set to null, as so don't then need a Noop implementation, and
later do a guard statement so the code can be compiled out if not enabled..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message