activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1295: ARTEMIS-1185 Inter-Process Journal Samp...
Date Mon, 29 May 2017 20:31:26 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1295#discussion_r118982620
  
    --- Diff: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.java
---
    @@ -288,7 +266,14 @@ private void flush(final boolean force) {
                 buffer.getBytes(0, bufferToFlush);
     
                 final List<IOCallback> ioCallbacks = callbacks == null ? Collections.emptyList()
: callbacks;
    -            bufferObserver.flushBuffer(bufferToFlush, pendingSyncs.get() > 0, ioCallbacks);
    +
    +            final boolean requiredSync = pendingSyncs.get() > 0;
    +            this.flushProfiler.onStartFlush(bufferToFlush.position(), requiredSync);
    --- End diff --
    
    why not a guard statement here? so if disabled the JVM would simply compile out the code
when disabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message