activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1291: Backwards compatibility + test fixes
Date Wed, 24 May 2017 23:25:23 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1291#discussion_r118388013
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
---
    @@ -1068,6 +1074,31 @@ private void deliverStandardMessage(final MessageReference ref,
final Message me
           }
        }
     
    +   private void applyPrefixForLegacyConsumer(Message message) {
    +      /**
    +       * check to see if:
    +       * 1) This is a "core" connection
    +       * 2) The "core" connection belongs to a JMS client
    +       * 3) The JMS client is an "old" client which needs address prefixes
    +       *
    +       * If 1, 2, & 3 are true then apply the "old" prefix for queues and topics
as appropriate.
    +       */
    +      if (session.getRemotingConnection() instanceof CoreRemotingConnection) {
    --- End diff --
    
    Can you please cache this during construction, and only apply this if the cached boolean
is set?
    
    This is part of the hot path for delivering messages.. so any gain counts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message