activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1289: ARTEMIS-1180: Artemis is logging warnin...
Date Wed, 24 May 2017 18:29:04 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1289#discussion_r118330425
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
---
    @@ -606,7 +610,8 @@ public void connectionFailed(final ActiveMQException me, boolean failedOver)
{
     
        @Override
        public void connectionFailed(final ActiveMQException me, boolean failedOver, String
scaleDownTargetNodeID) {
    -      ActiveMQServerLogger.LOGGER.bridgeConnectionFailed(failedOver);
    +      if(server.isStarted())
    +          ActiveMQServerLogger.LOGGER.bridgeConnectionFailed(failedOver);
    --- End diff --
    
    seems out of alignment to me.. this would fail checkstyle apparently.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message