activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1289: ARTEMIS-1180: Artemis is logging warnin...
Date Wed, 24 May 2017 13:46:18 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1289#discussion_r118256171
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
---
    @@ -719,7 +719,7 @@ void slowConsumerDetected(String sessionID,
        @Message(id = 222094, value = "Bridge unable to send message {0}, will try again once
bridge reconnects", format = Message.Format.MESSAGE_FORMAT)
        void bridgeUnableToSendMessage(@Cause Exception e, MessageReference ref);
     
    -   @LogMessage(level = Logger.Level.WARN)
    +   @LogMessage(level = Logger.Level.INFO)
    --- End diff --
    
    We had a talk on IRC about this:
    
    ```
    dtikhomi: customer is parsing logs, and in that case warn is false alarm for him
    [09:42am] clebert: but the thing is...
    [09:42am] clebert: when that issue is actually happening for a bad cause
    [09:42am] clebert: he won’t be alarmed for the real issue
    [09:42am] clebert: so .. that’s my concern
    [09:42am] clebert: nodes stop because of network outages...
    [09:43am] clebert: he won’t get notice
    [09:43am] dtikhomi: ohhh, i got it
    [09:43am] clebert: or missing connectiong because of outages
    [09:43am] clebert: u agree with me?
    [09:43am] dtikhomi: plz dont close PR i will update it
    [09:43am] dtikhomi: yeap, you right
    [09:44am] clebert: but do you think you know how to fix it with an easy fix?
    [09:44am] clebert: I thought it would be more substantial for a proper fix
    [09:44am] clebert: (like… is Shutting Down somewhere… ignore it)
    [09:44am] clebert: that’s actually the fix
    [09:44am] clebert: server.isStopping
    [09:44am] clebert: —> don’t log it
    [09:44am] clebert: or log.debug
    [09:44am] dtikhomi: yeap, i wonna try
    [09:45am] clebert: ok.. thanks a lot...
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message