activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1268: ARTEMIS-1162: Make new TimedBuffer Configurabl...
Date Sat, 13 May 2017 08:12:20 GMT
Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1268
  
    For me is ok to have an enum, but I mean that it doesn't make sense to have 2 TimedBuffer
implementations.
    You can have one with a flag in the constructor to disable the coalescing: this way the
behaviours will be the same as before, but with off heap batch buffer + bulk copy too.
    Then you can you an enum to set that flag or not: it is simpler to maintain IMHO.
    It is different if you want to maintain the older things that wasn't good (heap buffers
+ no bulk copy)...this is what you're proposing?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message