activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1263: ARTEMIS-1156: FIX: Long Autoboxing occurring o...
Date Wed, 10 May 2017 07:42:31 GMT
Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1263
  
    @michaelandrepearce Good work and great findings!
    My 2 cents on it, the new map is great but:
    1) it has a slightly different behaviour about atomic operations (eg [ConcurrentHashMap::compute
javadoc](https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentHashMap.html#compute-K-java.util.function.BiFunction-))
hence please checks if there are callers relying on such behaviours
    2)  it doesn't shrink/grow  like the vanilla ConcurrentHashMap -> when it grows it
is not incremental by little chuncks, but could put a lot of pressure on Humongous Allocations
hurting the heap allocations of byte[] performed during message translations    
    3) JournalCompactor in JournalImpl::compac is using a keySet from it (producing the unwanted
Longs
    
    So it is important to make sure that the common usage do not make them happen or at least
, that the benefits are well balanced by these drawbacks
    Anyway, the PR is great and I'm pretty happy about it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message