activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1258: ARTEMIS-898 - Adding documentation for Plugin ...
Date Mon, 08 May 2017 15:21:20 GMT
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1258
  
    Like how we load the ProtocolManagers...
    
    Each jar defines a org.apache.activemq.artemis.spi.core.protocol.ProtocolManagerFactory
file
    
    
    Then on RemotingServiceImpl::
    
    ```
       private void resolveProtocols(ClassLoader loader) {
          ServiceLoader<ProtocolManagerFactory> serviceLoader = ServiceLoader.load(ProtocolManagerFactory.class,
loader);
          loadProtocolManagerFactories(serviceLoader);
       }
    
       /**
        * Loads the protocols found into a map.
        *
        * @param protocolManagerFactoryCollection
        */
       private void loadProtocolManagerFactories(Iterable<ProtocolManagerFactory> protocolManagerFactoryCollection)
{
          for (ProtocolManagerFactory next : protocolManagerFactoryCollection) {
             MessagePersister.registerProtocol(next);
             String[] protocols = next.getProtocols();
             for (String protocol : protocols) {
                ActiveMQServerLogger.LOGGER.addingProtocolSupport(protocol, next.getModuleName());
                protocolMap.put(protocol, next);
             }
          }
       }
    ```
    
    
    Perhaps we could instruct users to do something similar. Just having this definition done.
    
    
    We would have to provide a XML property to resolve plugins, being defaulted to false if
we did this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message