activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1256: ARTEMIS-1151 Adapting TimedBuffer and N...
Date Mon, 08 May 2017 15:21:05 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1256#discussion_r115274444
  
    --- Diff: tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/TimedBufferTest.java
---
    @@ -205,162 +203,4 @@ public int getRemainingBytes() {
           }
     
        }
    -
    -   /**
    -    * This test will verify if the system will switch to spin case the system can't perform
sleeps timely
    -    * due to proper kernel installations
    -    *
    -    * @throws Exception
    -    */
    -   @Test
    --- End diff --
    
    Because the new implementation rely on LockSupport.parkNanos to wait (is a MONOTONIC clock
on linux AFAIK) and it doesn't wait never the whole time until the given expiration.
    In addition the background flusher use the Semaphore only after a "long" period of no
writes.
    The only practical reason that could lead it to not be triggered in time is dependent
by the writers: if a writers wait a lot to push data, the time could expire, but I think is
normal no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message