activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1256: ARTEMIS-1151 Adapting TimedBuffer and N...
Date Mon, 08 May 2017 15:00:44 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1256#discussion_r115269492
  
    --- Diff: tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/TimedBufferTest.java
---
    @@ -205,162 +203,4 @@ public int getRemainingBytes() {
           }
     
        }
    -
    -   /**
    -    * This test will verify if the system will switch to spin case the system can't perform
sleeps timely
    -    * due to proper kernel installations
    -    *
    -    * @throws Exception
    -    */
    -   @Test
    --- End diff --
    
    why did you remove this test? it was important when I added it.
    
    
    I would rather keep a method public and a test than remove a test to make a method private.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message