activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1242: ARTEMIS-898 - Adding Plugin Support
Date Tue, 02 May 2017 22:52:13 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1242#discussion_r114443703
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
    @@ -1808,6 +1822,33 @@ public void callPostQueueDeletionCallbacks(final SimpleString address,
        }
     
        @Override
    +   public void registerBrokerPlugins(final List<ActiveMQServerPlugin> plugins)
{
    +      configuration.registerBrokerPlugins(plugins);
    +   }
    +
    +   @Override
    +   public void registerBrokerPlugin(final ActiveMQServerPlugin plugin) {
    +      configuration.registerBrokerPlugin(plugin);
    +   }
    +
    +   @Override
    +   public void unRegisterBrokerPlugin(final ActiveMQServerPlugin plugin) {
    +      configuration.unRegisterBrokerPlugin(plugin);
    +   }
    +
    +   @Override
    +   public List<ActiveMQServerPlugin> getBrokerPlugins() {
    +      return configuration.getBrokerPlugins();
    +   }
    +
    +   @Override
    +   public void callPlugins(ActiveMQPluginRunnable pluginRun) {
    +      if (getBrokerPlugins().size() > 0) {
    --- End diff --
    
    Can this if statement be made before the runnable class is intsatiated? To avoid object
creation if no plugins


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message