activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tabish121 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...
Date Thu, 20 Apr 2017 14:57:51 GMT
Github user tabish121 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1215#discussion_r112475520
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java
---
    @@ -53,38 +56,61 @@
     import org.apache.qpid.proton.engine.Sender;
     import org.jgroups.util.UUID;
     import org.junit.Test;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Parameterized;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
     /**
      * Test basic send and receive scenarios using only AMQP sender and receiver links.
      */
    +@RunWith(Parameterized.class)
    --- End diff --
    
    This seems like an unnecessary change to this test.  The intent here is to test basic
AMQP protocol support not to test the FQQN support in the broker which it appears is already
done in the ProtonFullQualifiedNameTest.  I'd prefer if we could keep tests targeted and not
try and make them test the entirety of the broker features in one monolithic test case as
that makes it harder to maintain.  If you changed this one why didn't you change every single
AMQP test in the same fashion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message