activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1206: ARTEMIS-1116 - added role mapper for LDAP role...
Date Mon, 17 Apr 2017 18:28:04 GMT
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1206
  
    Thanks for fixing the commit message and checkstyle issues.
    
    The more I think about this the more I think this should be a general feature which all
login modules can use rather than just the LDAP login module. In general, this functionality
would only be useful for login modules pulling data from an external system like LDAP which
makes it a natural fit for the LDAP login module, but other users might implement their own
login module where this functionality would be useful (e.g. integrating with a legacy auth
system) and I wouldn't want to require a re-implementation. Also, I think moving the configuration
into broker.xml from login.config will be provide a better user experience.
    
    From a configuration perspective this would be a good fit in <security-settings>
next to <security-setting> and <security-setting-plugin>. The name <role-mapping>
seems appropriate. It could have a "from" and "to" attribute where "from" is delimited with
e.g. a comma.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message