activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1206: ARTEMIS-1116 - added role mapper for LDAP role...
Date Mon, 17 Apr 2017 14:12:02 GMT
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1206
  
    Couple of things:
    
    - The commit message should follow the format outlined in the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages).
    - You have a fair number of checkstyle violations. See more [here](https://builds.apache.org/blue/organizations/jenkins/ActiveMQ-Artemis-PR-Build/detail/ActiveMQ-Artemis-PR-Build/2607/pipeline).
You run the checkstyle stuff locally by using 'mvn -Pdev install'.
    - I wonder if this feature would be better if it was more general so that it could be
used with any login module rather than isolated only to the LDAP login module.  What do you
think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message