activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1183: ARTEMIS-1089 Improving flow control on replica...
Date Fri, 07 Apr 2017 08:34:28 GMT
Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1183
  
    I've a similar issue to solve [ARTEMIS-1098](https://issues.apache.org/jira/browse/ARTEMIS-1098)
but I'm trying to understand where is the best point where put the (connection) flow control
management.
    For my use case it could be:
    1. "hidden" in the [ChannelImpl::send](https://github.com/apache/activemq-artemis/blob/177480d8684fe0ecffa597878e07fb17ffcb5b8c/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java#L306)
for not batched writes (this will impact the streaming of large message AFAIK but maybe others
use cases)
    2.  implement a new method ChannelImpl::sendControlled (or similar) that will perform
flow controlled sends and will be called (right now) only by [ActiveMQSessionContext::sendLargeMessageChunk](https://github.com/apache/activemq-artemis/blob/177480d8684fe0ecffa597878e07fb17ffcb5b8c/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java#L468)
to reduce the impact on other use cases
    
    I'm not seeing (right now) other ways to do it, but I want to be consistent to what you've
done here: do you have any suggestions?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message