activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1176: ARTEMIS-1095 Netty's WriteBufferWaterMa...
Date Thu, 06 Apr 2017 13:00:56 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1176#discussion_r110154545
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/TransportConstants.java
---
    @@ -183,6 +187,10 @@
     
        public static final int DEFAULT_TCP_RECEIVEBUFFER_SIZE = 1024 * 1024;
     
    +   public static final int DEFAULT_NETTY_WRITE_BUFFER_LOW_WATER_MARK = 32 * 1024;
    --- End diff --
    
    In theory the 2 values are not dependent:  TCP will fragment the data if bigger than its
MTU (1460 bytes for Ethernet + TCPv4), hence you could have any size for the TCP buffer (>=MTU
AFAIK).
    The water marks values affect only the buffering performed by Netty and how many times
it will call channelWritabilityChanged, dependently by our writing rate and size.
    By consequence it will change how many times channel::isWritable will be true.
    I've used the doc and http://normanmaurer.me/presentations/2014-twitter-meetup-netty/slides.html#9.0
and http://normanmaurer.me/presentations/2014-twitter-meetup-netty/slides.html#10.0 to have
an idea about it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message