activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1176: ARTEMIS-1095 Netty's WriteBufferWaterMa...
Date Thu, 06 Apr 2017 12:50:33 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1176#discussion_r110152342
  
    --- Diff: docs/user-manual/en/configuring-transports.md ---
    @@ -239,6 +239,17 @@ Netty for simple TCP:
     -   `tcpReceiveBufferSize`. This parameter determines the size of the
         TCP receive buffer in bytes. The default value for this property is
         `32768` bytes (32KiB).
    +    
    +-   `nettyWriteBufferLowWaterMark`. This parameter determines the low water mark of 
    +    the Netty write buffer. Once the number of bytes queued in the write buffer exceeded

    +    the high water mark and then dropped down below this value, Netty's channel 
    +    will start to be writable again. The default value for this property is 
    +    `32768` bytes (32KiB).
    + 
    +-   `nettyWriteBufferHighWaterMark`. This parameter determines the high water mark of

    +    the Netty write buffer. If the number of bytes queued in the write buffer exceeds

    +    this value, Netty's channel will start to be not writable. The default value for

    +    this property is `131072` bytes (128KiB).
    --- End diff --
    
    Can you add a test where you validate this parameter through an URI?
    
    Look for a test parsing the Connector and Acceptor, and validate if the value was parsed,
please?
    
    
    
    I will need this PR done ASAP, as I was doing something similar on my replication tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message