activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1176: ARTEMIS-1095 Netty's WriteBufferWaterMa...
Date Thu, 06 Apr 2017 12:48:55 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1176#discussion_r110151986
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/TransportConstants.java
---
    @@ -125,6 +125,10 @@
         */
        public static final String NIO_REMOTING_THREADS_PROPNAME = "nioRemotingThreads";
     
    +   public static final String NETTY_WRITE_BUFFER_LOW_WATER_MARK_PROPNAME = "nettyWriteBufferLowWaterMark";
    --- End diff --
    
    If you are exposing the parameter to users, can you rename it as bufferLowWatermark
    and bufferHighWaternark?
    
    It's more independent from Netty and more user friendly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message