Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Tue, 7 Mar 2017 11:06:47 -0500 (EST)
From: Justin Bertram <jbertram@apache.org>
To: dev@activemq.apache.org
Message-ID: <344078427.43183960.1488902807405.JavaMail.zimbra@redhat.com>
In-Reply-To: <CA+S-PUKsWbtpUm=yoitbgbOD3HVOCZrNivd3Y1ry=2X6L2hwtQ@mail.gmail.com>
References: <CAH6wpnrJ0NzvKjvdcgc6qnug1cpu-tairo4vYCOBmV_9VqXNHg@mail.gmail.com> <CAKF+bspLu+5TZJM1B8qTAKVoEqfjuCCnygBXPoxv0Z_2Txn-kA@mail.gmail.com> <CAKF+bspx-ua-ynfNB_MGoYLxf6bdPFz8ni1Z0jYuL+nPiGoPtg@mail.gmail.com> <1940993549.29726357.1486766728347.JavaMail.zimbra@redhat.com> <CAKF+bsrEaw6jd7tU8bJstRGV0sAbL335FSEP8Cw1Amg+NTzruA@mail.gmail.com> <CA+S-PUKpP8pdNT92pujcAugbua_o-mE+dTgSUAEM0jpWHh1GuQ@mail.gmail.com> <CAH6wpno=2etZf8G0G3tkC02GR6UW8buvehjH7Z5HAW32sLrenw@mail.gmail.com> <CA+S-PUKsWbtpUm=yoitbgbOD3HVOCZrNivd3Y1ry=2X6L2hwtQ@mail.gmail.com>
Subject: Re: [DISCUSS] ActiveMQ Artemis 2.x stream
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Thread-Topic: ActiveMQ Artemis 2.x stream
Thread-Index: 1ZSEpNT5s7OFgQzi3i/oIPeOG3//yA==
archived-at: Tue, 07 Mar 2017 16:06:58 -0000

> <slow-consumer-threshold time-unit=3D"1m">10</slow-consumer-threshold>

I would suggest something more akin to what was implemented for byte fields=
 (i.e. support notation like "KB", "M", "gb", etc.).  For example:

  <slow-consumer-threshold>10m</slow-consumer-threshold>

or

  <slow-consumer-threshold>30s</slow-consumer-threshold>

And default to whatever time-unit is used now.


Justin


----- Original Message -----
From: "Jiri Danek" <jdanek@redhat.com>
To: dev@activemq.apache.org
Sent: Tuesday, March 7, 2017 10:01:13 AM
Subject: Re: [DISCUSS] ActiveMQ Artemis 2.x stream

On Tue, Mar 7, 2017 at 4:23 PM, Martyn Taylor <mtaylor@redhat.com> wrote:

> Hi Jiri,
>
> Thanks for bringing this up again.
>
> One approach to this that avoids having to add new settings or change the
> default values of current config  would be to add a unit parameter to the
> configuration element.  For example
>
> <!-- 10 messages per 1 minute -->
> <slow-consumer-threshold time-unit=3D"1m">10</slow-consumer-threshold>
>
> This is just an example, but we could standardise across all configuraito=
n
> options by just passing in "unit".
>
> This way users are free to express units that they are familiar with
> (msg/s) for example is a typical measurement, however, it could be messag=
es
> per minute or what ever you want.
>
> Does this sound reasonable?
>

Hi, yes, that would resolve the usecase I had in mind in such a way that
current configuration files stay compatible. Sorry for derailing the 2.x
stream thread. I am looking forward to that release soonest.

Best of wishes,


>
> Cheers
>
> On Tue, Mar 7, 2017 at 2:12 PM, Jiri Danek <jdanek@redhat.com> wrote:
>
> > I somehow buried this thread, sorry...
> >
> > On Fri, Feb 10, 2017 at 11:54 PM, Clebert Suconic <
> > clebert.suconic@gmail.com
> > > wrote:
> >
> > > you're right.. I was just trying to understand Jiri's comment, and no=
t
> > > actually make an evaluation on the feature.
> > >
> >
> > When I wrote the comment, I was confused about the units. I somehow
> thought
> > that both <slow-consumer-threshold> and <slow-consumer-check-period> we=
re
> > meant to be in minutes, but by some mistake it got coded in seconds and
> > then it was not possible to change it because of backwards
> compatibility. I
> > thought that 2.0.0 release could be a good point to make it right.
> >
> > In fact, I think that <slow-consumer-threshold> should be in minutes,
> > because if it is in seconds, the lowest message rate that it is possibl=
e
> to
> > specify is 1 msg/s. I imagine it may be too high for some users who sen=
d
> > very large messages or messages where processing of each takes a very
> long
> > time. Minutes as a unit would increase the range of possible values.
> >
> > I'll think more about this and either start a new thread, or wait for
> Miro
> > to start it (in case he feels the need to discuss the slow consumers
> > feature in relation to the Jira he opened), or just leave it be.
> > --
> > Ji=C5=99=C3=AD Dan=C4=9Bk
> > Messaging QA
> >
>


--=20
Ji=C5=99=C3=AD Dan=C4=9Bk
Messaging QA