Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: jbertram <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1139-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1139-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1139: ARTEMIS-1074 Acceptors/Connectors now s...
Content-Type: text/plain
Message-Id: <20170328030118.0BF0ADFBCA@git1-us-west.apache.org>
Date: Tue, 28 Mar 2017 03:01:18 +0000 (UTC)
archived-at: Tue, 28 Mar 2017 03:01:20 -0000

Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1139#discussion_r108325677
  
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java ---
    @@ -20,6 +20,8 @@
     import javax.crypto.SecretKeyFactory;
     import javax.crypto.spec.PBEKeySpec;
     import javax.crypto.spec.SecretKeySpec;
    +import javax.naming.ConfigurationException;
    --- End diff --
    
    I don't think this is the proper exception to use here as this method has nothing to do with naming (e.g. JNDI).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---