Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: clebertsuconic <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1098-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1098-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1098: ARTEMIS-1042 - support amqp failover li...
Content-Type: text/plain
Message-Id: <20170317190719.0D1E8DFE1E@git1-us-west.apache.org>
Date: Fri, 17 Mar 2017 19:07:19 +0000 (UTC)
archived-at: Fri, 17 Mar 2017 19:07:20 -0000

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1098#discussion_r106419741
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java ---
    @@ -129,6 +131,22 @@ public String toURI() {
           return "tcp://" + host + ":" + port;
        }
     
    +   public URI toBackupURI() {
    +      TransportConfiguration backupConnector = getBackup();
    +      if (backupConnector == null) {
    +         return null;
    --- End diff --
    
    Instead of returning null, can't we return the other members on the list?
    
    I foresee a lot of cases where users don't have backup servers on the cloud.. and just have the infra-structure reconnecting them from data.
    
    Can you provide other nodes as a list here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---