activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1081: ARTEMIS-1011 adjust slow-consumer detec...
Date Thu, 09 Mar 2017 20:41:03 GMT
GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1081

    ARTEMIS-1011 adjust slow-consumer detection logic

    Adjust slow-consumer detection logic to use the number of messages in
    the queue and not just the number of messages added since the last
    check. This means the getRate() method now returns the rate of messages
    which it *could* have dispatched since the last check rather than the
    rate at which it received messages. This is a more reliable metric to
    ensure the slow-consumer detection logic doesn't flag a consumer as
    slow unfairly. Althoug the reliability will come at a performance cost
    since getMessageCount() must lock the queue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1011

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1081.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1081
    
----
commit 85ddb298bc97a4caddd1cedbfad8d03eb8a725da
Author: Justin Bertram <jbertram@apache.org>
Date:   2017-03-09T14:11:00Z

    ARTEMIS-1011 adjust slow-consumer detection logic
    
    Adjust slow-consumer detection logic to use the number of messages in
    the queue and not just the number of messages added since the last
    check. This means the getRate() method now returns the rate of messages
    which it *could* have dispatched since the last check rather than the
    rate at which it received messages. This is a more reliable metric to
    ensure the slow-consumer detection logic doesn't flag a consumer as
    slow unfairly. Althoug the reliability will come at a performance cost
    since getMessageCount() must lock the queue.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message