activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Miroslav Novak <mno...@redhat.com>
Subject Re: [DISCUSS] ActiveMQ Artemis 2.x stream
Date Wed, 08 Mar 2017 10:46:22 GMT
Thanks Martyn, I just had this impression from the code and wanted to check it with you in
[1] . Let's leave it as it is and not break things.

Mirek

[1] https://issues.apache.org/jira/browse/ARTEMIS-1001?focusedCommentId=15887539&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15887539

----- Original Message -----
> From: "Martyn Taylor" <mtaylor@redhat.com>
> To: dev@activemq.apache.org
> Sent: Wednesday, March 8, 2017 11:07:19 AM
> Subject: Re: [DISCUSS] ActiveMQ Artemis 2.x stream
> 
> Mirek,
> 
> I'd prefer not to change the default value, but instead make our
> configuration options include a units parameter.  If we add a units
> parameter like discussed above users can specify however which way they'd
> like to time slice their window, changing it to only support 5 minutes
> might be great for you, but not so great for other users.
> 
> I think this applies to many other configuration options where units are
> currently fixed.  I don't think we need to break and API or configuration
> to resolve this, let's just extend it to give users more control.
> 
> Cheers
> Martyn
> 
> On Wed, Mar 8, 2017 at 6:57 AM, Miroslav Novak <mnovak@redhat.com> wrote:
> 
> > I would like only to change default value for attribute
> > "slow-consumer-check-period' from 5 seconds to 5 minutes. I believe it was
> > original intention. Calculating msg/s rate based on 5 second time window
> > might be very inaccurate.
> 
> 
> > Mirek
> >
> > ----- Original Message -----
> > > From: "Martyn Taylor" <mtaylor@redhat.com>
> > > To: dev@activemq.apache.org
> > > Sent: Tuesday, March 7, 2017 5:48:42 PM
> > > Subject: Re: [DISCUSS] ActiveMQ Artemis 2.x stream
> > >
> > > This specific field is message consumption rate, i.e. no message per time
> > > window.  So we would need something like:
> > >
> > > <slow-consumer-threshold>10msg/minute</slow-consumer-threshold>
etc...
> > >
> > > I don't mind either way, as a unit parameter or as part of the value.
> > > Either way, we don't need to break configuration to add this improvement.
> > >
> > > Cheers
> > >
> > > On Tue, Mar 7, 2017 at 4:11 PM, Clebert Suconic <
> > clebert.suconic@gmail.com>
> > > wrote:
> > >
> > > > On Tue, Mar 7, 2017 at 11:06 AM Justin Bertram <jbertram@apache.org>
> > > > wrote:
> > > >
> > > > > > <slow-consumer-threshold time-unit="1m">10</slow-
> > consumer-threshold>
> > > > >
> > > > > I would suggest something more akin to what was implemented for byte
> > > > > fields (i.e. support notation like "KB", "M", "gb", etc.).  For
> > example:
> > > > >
> > > > >   <slow-consumer-threshold>10m</slow-consumer-threshold>
> > > > >
> > > > > or
> > > > >
> > > > >   <slow-consumer-threshold>30s</slow-consumer-threshold>
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > +1000
> > > >
> > > > >
> > > > > And default to whatever time-unit is used now.
> > > > >
> > > > >
> > > > > Justin
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > From: "Jiri Danek" <jdanek@redhat.com>
> > > > > To: dev@activemq.apache.org
> > > > > Sent: Tuesday, March 7, 2017 10:01:13 AM
> > > > > Subject: Re: [DISCUSS] ActiveMQ Artemis 2.x stream
> > > > >
> > > > > On Tue, Mar 7, 2017 at 4:23 PM, Martyn Taylor <mtaylor@redhat.com>
> > > > wrote:
> > > > >
> > > > > > Hi Jiri,
> > > > > >
> > > > > > Thanks for bringing this up again.
> > > > > >
> > > > > > One approach to this that avoids having to add new settings
or
> > change
> > > > the
> > > > > > default values of current config  would be to add a unit parameter
> > to
> > > > the
> > > > > > configuration element.  For example
> > > > > >
> > > > > > <!-- 10 messages per 1 minute -->
> > > > > > <slow-consumer-threshold time-unit="1m">10</slow-
> > consumer-threshold>
> > > > > >
> > > > > > This is just an example, but we could standardise across all
> > > > > configuraiton
> > > > > > options by just passing in "unit".
> > > > > >
> > > > > > This way users are free to express units that they are familiar
> > with
> > > > > > (msg/s) for example is a typical measurement, however, it could
be
> > > > > messages
> > > > > > per minute or what ever you want.
> > > > > >
> > > > > > Does this sound reasonable?
> > > > > >
> > > > >
> > > > > Hi, yes, that would resolve the usecase I had in mind in such a way
> > that
> > > > > current configuration files stay compatible. Sorry for derailing
the
> > 2.x
> > > > > stream thread. I am looking forward to that release soonest.
> > > > >
> > > > > Best of wishes,
> > > > >
> > > > >
> > > > > >
> > > > > > Cheers
> > > > > >
> > > > > > On Tue, Mar 7, 2017 at 2:12 PM, Jiri Danek <jdanek@redhat.com>
> > wrote:
> > > > > >
> > > > > > > I somehow buried this thread, sorry...
> > > > > > >
> > > > > > > On Fri, Feb 10, 2017 at 11:54 PM, Clebert Suconic <
> > > > > > > clebert.suconic@gmail.com
> > > > > > > > wrote:
> > > > > > >
> > > > > > > > you're right.. I was just trying to understand Jiri's
comment,
> > and
> > > > > not
> > > > > > > > actually make an evaluation on the feature.
> > > > > > > >
> > > > > > >
> > > > > > > When I wrote the comment, I was confused about the units.
I
> > somehow
> > > > > > thought
> > > > > > > that both <slow-consumer-threshold> and
> > <slow-consumer-check-period>
> > > > > were
> > > > > > > meant to be in minutes, but by some mistake it got coded
in
> > seconds
> > > > and
> > > > > > > then it was not possible to change it because of backwards
> > > > > > compatibility. I
> > > > > > > thought that 2.0.0 release could be a good point to make
it
> > right.
> > > > > > >
> > > > > > > In fact, I think that <slow-consumer-threshold> should
be in
> > minutes,
> > > > > > > because if it is in seconds, the lowest message rate that
it is
> > > > > possible
> > > > > > to
> > > > > > > specify is 1 msg/s. I imagine it may be too high for some
users
> > who
> > > > > send
> > > > > > > very large messages or messages where processing of each
takes a
> > very
> > > > > > long
> > > > > > > time. Minutes as a unit would increase the range of possible
> > values.
> > > > > > >
> > > > > > > I'll think more about this and either start a new thread,
or
> > wait for
> > > > > > Miro
> > > > > > > to start it (in case he feels the need to discuss the slow
> > consumers
> > > > > > > feature in relation to the Jira he opened), or just leave
it be.
> > > > > > > --
> > > > > > > Jiří Daněk
> > > > > > > Messaging QA
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Jiří Daněk
> > > > > Messaging QA
> > > > >
> > > > --
> > > > Clebert Suconic
> > > >
> > >
> >
> 

Mime
View raw message