activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1119: ARTEMIS-1025 OutOfDirectMemoryError raised fro...
Date Fri, 31 Mar 2017 21:10:04 GMT
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1119
  
    I see what you're doing now... if !isWritable, it think it should perform a flush and
block the thread...
    
    
    We should always avoid actually calling write while isWritable...
    
    
    
    I think this needs some simplification though...
    
    
    i - just call a simple writeAndflush if beyond the limit... you may add a log.debug (**debug**)
statement if it needed to flush for the lack of flow control from our codebase. We can use
a fixed timeout here.. and log.warn if missed. We have a callback timeout already.. we should
just reuse the same. (the less properties to be configured the better).
    
    ii - that means no more crazy properties.
    
    
    We may talk on monday about this.. but this is getting shape for me now.. we just need
to clear the PR before we merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message