activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yourcaptain <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1134: ARTEMIS-1071 Invalid Type exception han...
Date Wed, 29 Mar 2017 01:13:34 GMT
Github user yourcaptain commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1134#discussion_r108573779
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/util/JMSTestBase.java
---
    @@ -197,21 +198,33 @@ protected void registerConnectionFactory() throws Exception {
           List<TransportConfiguration> connectorConfigs = new ArrayList<>();
           connectorConfigs.add(new TransportConfiguration(INVM_CONNECTOR_FACTORY));
     
    +      List<TransportConfiguration> connectorConfigs1 = new ArrayList<>();
    +      connectorConfigs1.add(new TransportConfiguration(NETTY_CONNECTOR_FACTORY));
    +
           createCF(connectorConfigs, "/cf");
    +      createCF("NettyCF", connectorConfigs1, "/nettyCf");
     
           cf = (ConnectionFactory) namingContext.lookup("/cf");
    +      nettyCf = (ConnectionFactory)namingContext.lookup("/nettyCf");
    +   }
    +
    +   protected void createCF(final List<TransportConfiguration> connectorConfigs,
    +                           final String... jndiBindings) throws Exception {
    +      createCF(name.getMethodName(), connectorConfigs, jndiBindings);
        }
     
    +
        /**
         * @param connectorConfigs
         * @param jndiBindings
         * @throws Exception
         */
    -   protected void createCF(final List<TransportConfiguration> connectorConfigs,
    +   protected void createCF(final String cfName,
    +                           final List<TransportConfiguration> connectorConfigs,
    --- End diff --
    
    cfName should be added to comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message