activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gemmellr <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1138: ARTEMIS-1073 Adding configuration for P...
Date Tue, 28 Mar 2017 11:29:09 GMT
Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1138#discussion_r108394942
  
    --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/broker.xml
---
    @@ -61,10 +61,13 @@ ${ping-config.settings}${journal-buffer.settings}${connector-config.settings}
           <global-max-size>100Mb</global-max-size>
     
           <acceptors>
    +
              <!-- useEpoll means: it will use Netty epoll if you are on a system (Linux)
that supports it -->
    +         <!-- amqpCredits: The number of credits sent to AMQP producers -->
    +         <!-- amqpLowCredits: The server will send the # credits specified at amqpCredits
at this low mark -->
    --- End diff --
    
    Should there maybe be some coverage of these options in the documentation? Do we think
enough people will tweak them that they should be in the default configuration file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message