activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gemmellr <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1138: ARTEMIS-1073 Adding configuration for P...
Date Tue, 28 Mar 2017 11:29:09 GMT
Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1138#discussion_r108394675
  
    --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/amqp-acceptor.txt
---
    @@ -1,3 +1,3 @@
     
              <!-- AMQP Acceptor.  Listens on default AMQP port for AMQP traffic.-->
    -         <acceptor name="amqp">tcp://${host}:${amqp.port}?protocols=AMQP;useEpoll=true</acceptor>
    +         <acceptor name="amqp">tcp://${host}:${amqp.port}?protocols=AMQP;useEpoll=true;amqpCredits=1000;amqpMinCredits=300</acceptor>
    --- End diff --
    
    This configures 'amqpMinCredits', whereas broker.xml configures 'amqpLowCredits', is one
of them wrong? If not, perhaps it would be clearer if they were the same?
    
    It might also be clearer to rationalise the naming in the code as well, it seems to use
'amqpLowMark', 'amqpLowCredits', and 'minCreditRefresh' to refer to this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message