activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1055: Add default constructor for reflection
Date Wed, 01 Mar 2017 14:35:37 GMT
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1055
  
    Couple of things...
    
    - Your commit message should follow the 50/72 format as outlined in the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages).
    - The commit message really isn't the place for a stack trace and explanation of the problem.
 Please create a JIRA for that.
    - If at all possible every fix should include a test to validate the fix is correct (i.e.
without the fix the test fails).
    - Your commit failed the PR check because:
    
    `[ERROR] src/main/java/org/apache/activemq/artemis/core/protocol/hornetq/HQPropertiesConversionInterceptor.java:[34]
(regexp) RegexpSingleline: Line has trailing spaces.`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message