Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6109D200C1B for ; Tue, 14 Feb 2017 15:29:16 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5F9CC160B5F; Tue, 14 Feb 2017 14:29:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A90EB160B52 for ; Tue, 14 Feb 2017 15:29:15 +0100 (CET) Received: (qmail 25247 invoked by uid 500); 14 Feb 2017 14:29:14 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 25236 invoked by uid 99); 14 Feb 2017 14:29:14 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2017 14:29:14 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7743ADFCA3; Tue, 14 Feb 2017 14:29:14 +0000 (UTC) From: jmesnil To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org Message-ID: Subject: [GitHub] activemq-artemis pull request #1013: [ARTEMIS-963] Prevent ClassCastExcepti... Content-Type: text/plain Date: Tue, 14 Feb 2017 14:29:14 +0000 (UTC) archived-at: Tue, 14 Feb 2017 14:29:16 -0000 GitHub user jmesnil opened a pull request: https://github.com/apache/activemq-artemis/pull/1013 [ARTEMIS-963] Prevent ClassCastException in ActiveMQChannelHandler When HTTP Upgrade is enabled, update Netty's pipeline only after the HTTP Upgrade handshake is successful *and* the trailing EMPTY_LAST_CONTENT is received. Otherwise, this EMPTY_LAST_CONTENT is handled by ActiveMQChannelHandler which is only expected to handle ByteBuf JIRA: https://issues.apache.org/jira/browse/ARTEMIS-963 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jmesnil/activemq-artemis ARTEMIS-963_ClassCastException_ActiveMQChannelHandler Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1013.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1013 ---- commit 2044fe97901255694fa03ac11a83906601349b5c Author: Jeff Mesnil Date: 2017-02-14T14:25:39Z [ARTEMIS-963] Prevent ClassCastException in ActiveMQChannelHandler When HTTP Upgrade is enabled, update Netty's pipeline only after the HTTP Upgrade handshake is successful *and* the trailing EMPTY_LAST_CONTENT is received. Otherwise, this EMPTY_LAST_CONTENT is handled by ActiveMQChannelHandler which is only expected to handle ByteBuf JIRA: https://issues.apache.org/jira/browse/ARTEMIS-963 ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---