activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1007: ARTEMIS-958 Improve web server tmp dir ...
Date Mon, 13 Feb 2017 15:15:27 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1007#discussion_r100815172
  
    --- Diff: artemis-web/src/main/java/org/apache/activemq/artemis/ActiveMQWebLogger.java
---
    @@ -57,4 +57,8 @@
        @LogMessage(level = Logger.Level.WARN)
        @Message(id = 244003, value = "Temporary file not deleted on shutdown: {0}", format
= Message.Format.MESSAGE_FORMAT)
        void tmpFileNotDeleted(File tmpdir);
    +
    +   @LogMessage(level = Logger.Level.DEBUG)
    --- End diff --
    
    We don't need to use the Logger for Debug Messages...
    
    
    just make these calls
    
    
    
    on the declarion of the class: private static final Logger logger = Logger.getLogger(...);
// use the right package here.. and there are other examples you can follow...
    
    
    
    and then log.debug(".... .static text...")
    
    
    
    These messages are for INFO, WARN, ERROR.. or things that will need a code to be printed
out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message