activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Bertram <jbert...@apache.org>
Subject Re: [DISCUSS] ActiveMQ Artemis 2.x stream
Date Fri, 10 Feb 2017 22:45:28 GMT
The <slow-consumer-threshold> property configures how many messages-per-second a consumer
needs to ack before it will be considered "slow."

The <slow-consumer-check-period> property configures how many minutes to wait between
checks for "slow" consumers.

The two properties are pretty straight-forward, and I personally don't see how making them
use the same time unit makes things simpler.  Granting such a change does make things marginally
more simple, is that sufficient to justify the code change, documentation change, and the
likely questions when things don't work like 1.x users expect?

If we really wanted to make this change then I'd recommend changing <slow-consumer-check-period>
to be in seconds as that would be the simpler code change, and that change would have a smaller
impact on users who are actually configuring this and who may not actually notice the different
semantics.  For example, checking for slow consumers every 3 seconds rather than every 3 minutes
would have less of an impact than the potential message build-up you'd have if your slow consumers
were calculated at 5 messages-per-minute rather than 5 messages-per-second.


Justin

----- Original Message -----
From: "Clebert Suconic" <clebert.suconic@gmail.com>
To: dev@activemq.apache.org
Sent: Friday, February 10, 2017 4:07:14 PM
Subject: Re: [DISCUSS] ActiveMQ Artemis 2.x stream

although we could deprecate this xml tag, and add a new one with some
creative name... add exceptions on the logs.. what would make it
suitable for even a minor update, on which case this would bee a
regular issue.

On Fri, Feb 10, 2017 at 5:06 PM, Clebert Suconic
<clebert.suconic@gmail.com> wrote:
> I guess it's just simplification? one is in seconds, the other is in minutes?
>
> It seems something we should fix.. but it needs to be done on a major
> release. (it would break minor updates).
>
> On Fri, Feb 10, 2017 at 4:58 PM, Justin Bertram <jbertram@apache.org> wrote:
>> What's the use-case for needing to "align" <slow-consumer-threshold> and <slow-consumer-check-period>?
>>
>>
>> Justin
>>
>> ----- Original Message -----
>> From: "Jiri Danek" <jdanek@redhat.com>
>> To: dev@activemq.apache.org
>> Sent: Friday, February 10, 2017 3:26:01 PM
>> Subject: Re: [DISCUSS] ActiveMQ Artemis 2.x stream
>>
>> On Thu, Feb 9, 2017 at 1:18 PM, Martyn Taylor <mtaylor@redhat.com> wrote:
>>
>>> I'd like to open discussion around this topic, does anyone have any
>>> suggestions, or can think of anything that is needed before we go ahead
>>> with a major release? This is the perfect time to do anything that could
>>> break APIs, drop deprecated methods support, break data format etc...
>>>
>>
>> What about changing units on config option
>>
>> <slow-consumer-threshold>100</slow-consumer-threshold>
>>
>> currently it is in messages/second, I suggest using messages/minute, to
>> align it with
>>
>> <slow-consumer-check-period>5</slow-consumer-check-period>
>>
>> which is in minutes.
>>
>> --
>> Jiří Daněk
>
>
>
> --
> Clebert Suconic



-- 
Clebert Suconic

Mime
View raw message