Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: clebertsuconic <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-956-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-956-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #956: ARTEMIS-915 WebComponent stopped when ba...
Content-Type: text/plain
Message-Id: <20170112035001.6DBE3DFAEB@git1-us-west.apache.org>
Date: Thu, 12 Jan 2017 03:50:01 +0000 (UTC)
archived-at: Thu, 12 Jan 2017 03:50:03 -0000

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/956#discussion_r95721658
  
    --- Diff: artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java ---
    @@ -170,4 +173,15 @@ private WebAppContext deployWar(String url, String warFile, Path warDirectory) t
           handlers.addHandler(webapp);
           return webapp;
        }
    +
    +   @Override
    +   public void stop() throws Exception {
    --- End diff --
    
    @gaohoward if someone called stop() directly, I would expect it to really shutdown.
    
    But I guess it's ok this way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---