activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #960: ARTEMIS-921 Consumers killed as slow eve...
Date Mon, 16 Jan 2017 14:38:46 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/960#discussion_r96241875
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
    @@ -3159,6 +3162,9 @@ public void run() {
                             connection.killMessage(server.getNodeID());
                             remotingService.removeConnection(connection.getID());
                             connection.fail(ActiveMQMessageBundle.BUNDLE.connectionsClosedByManagement(connection.getRemoteAddress()));
    +                        //break once a consumer gets killed. This can prevent all
    +                        //consumers to this queue get killed all at once.
    +                        break;
    --- End diff --
    
    you will also need to change your test as you made an assumption a consumer would be killed.
Since the overal rate doesn't satisfy the condition of the threshold no consumers should be
killed..
    
    
    @gaohoward I will let you handle these changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message